Log4j2 JsonLayout support #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
============================================
+ Coverage 70.60% 70.61% +0.01%
- Complexity 9794 9799 +5
============================================
Files 817 817
Lines 39489 39501 +12
Branches 5995 5999 +4
============================================
+ Hits 27880 27894 +14
+ Misses 8902 8900 -2
Partials 2707 2707 ☔ View full report in Codecov by Sentry. |
…nto two modules to support log4j 2.6-2.14 and 2.15+
…was already added by other logger instrumentation (e.g. JUL).
meiao
approved these changes
Oct 23, 2023
...ion/apache-log4j-2/src/main/java/org/apache/logging/log4j/core/LogEvent_Instrumentation.java
Outdated
Show resolved
Hide resolved
meiao
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to a previous PR that was reverted to address verifier failures: #1545
This PR re-introduces the Log4j2
JsonLayoutsupport but splits Log4j2 instrumentation across two modules.apache-log4j-2.6is a new instrumentation modules for older versions of Log4j2 (versions 2.6 - 2.10.0). It's simply a copy of theapache-log4j-2(versions 2.11.0+) module but with a few tweaks required to avoid verifier failures with those older versions.